thanos icon indicating copy to clipboard operation
thanos copied to clipboard

Published 20 hours ago • verified publisher icon thanos-io

compact: native histogram support for downsampling

Open rabenhorst opened this issue 1 year ago • 5 comments

This PR adds native histogram support for downsampling in compact and is part of https://github.com/thanos-io/thanos/issues/5907.

  • [x] I added CHANGELOG entry for this change.
  • [ ] Change is not relevant to the end user.

Changes

  • Add native histogram support for downsampling

Verification

  • Add unit tests for native histograms in downsampling

rabenhorst avatar May 09 '23 12:05 rabenhorst

We get this feedback consistently that Thanos is hard to understand and we are adding quite new functionality here thus could you please add a paragraph to docs/components/compact.md about how native histogram downsampling works?

Agreed. I will ad documentation about it.

rabenhorst avatar Aug 29 '23 08:08 rabenhorst

Any update on this? Would be cool to merge it.

GiedriusS avatar Feb 22 '24 12:02 GiedriusS

This seems to be the last piece missing to fully support native histograms in Thanos. Can we help in any way so this can get merged?

Matroxt avatar Jun 05 '24 00:06 Matroxt

This seems to be the last piece missing to fully support native histograms in Thanos. Can we help in any way so this can get merged?

You can open up a separate PR using commits from this branch and then add extra fixes on top

GiedriusS avatar Jun 05 '24 08:06 GiedriusS

This seems to be the last piece missing to fully support native histograms in Thanos. Can we help in any way so this can get merged?

I don't had/have the time continue working on this. As @GiedriusS wrote, feel free to jut copy my branch. If you have question you can put them here or find me in CNCF slack.

rabenhorst avatar Jun 05 '24 09:06 rabenhorst