thanos
thanos copied to clipboard
proxy: pre-calculate hash at leaf nodes
Is your proposal related to a problem?
We could increase the performance by calculating the hash of a chunk at the leaf node instead of the querier: https://github.com/thanos-io/thanos/pull/5296#discussion_r966899425
Describe the solution you'd like
Add another field with the hash and use it.
Add another field with the hash and use it.
Can you please elaborate more on where to add the field for hashes? The Series
API?
Once we have more details here, I would be inclined to take a stab at solving this one.
Idea is to calculate this hash by the sender so that it would be less work on the querier (:
https://github.com/thanos-io/thanos/blob/32a6c4e03a/pkg/store/storepb/types.proto#L23 If I understand correctly, we can add one more nullable hash field to the chunk itself and populate it at stores?
@GiedriusS can we close this in light of #5703 ?
Yep :+1: thanks for your work on this! :muscle: