thanos icon indicating copy to clipboard operation
thanos copied to clipboard

*: move to protobuf v2 api + vtprotobuf

Open GiedriusS opened this issue 2 years ago • 1 comments

Builds on top of our previous work. I think we could merge this on green.

Pros:

  • We are getting rid of a huge unmaintained dependency;
  • It unblocks enabling pooling for SeriesResponses.

Implementation notes:

  • We are now downloading protoc compiler with needed includes from the Vitess project; in the future let's do this package ourselves? This is needed because IIRC upstream doesn't provide a trimmed zip with only the compiler + protobuf includes
  • All generated types became pointers because upstream protobuf v2 API doesn't support the previously used extension
  • ~~I think this will force all of our downstream users i.e. Cortex/Mimir to upgrade to the protobuf V2 API~~ now that Cortex is in included in our repo, I have made the respective changes + regenerated protobuf files using the new compiler

TODO in future PRs:

  • Bring back ZLabels - it's a bit trickier now because we will have to use sed to delete methods;

GiedriusS avatar Jun 14 '22 11:06 GiedriusS

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 21 '22 00:09 stale[bot]

@GiedriusS what's missing here? (Except resolving that terrible conflict list :slightly_smiling_face:) Any way to support here?

matej-g avatar Oct 06 '22 06:10 matej-g

Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days. Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Nov 12 '22 12:11 stale[bot]