thanos icon indicating copy to clipboard operation
thanos copied to clipboard

add proposal for parallel compaction

Open roystchiang opened this issue 3 years ago • 4 comments

  • [ ] I added CHANGELOG entry for this change.
  • [X] Change is not relevant to the end user.

Changes

A proposal for scaling compactor via compacting of blocks for a single tenant in parallel. We have something similar in Cortex with https://cortexmetrics.io/docs/proposals/parallel-compaction/. I'm thinking that since Cortex uses Thanos under the hood for compaction, it would be beneficial for both projects if we can coordinate our effort on making compactor scale better, instead of having two projects work on their own solution.

I'm hoping that with this proposal, Cortex will be able to reuse the planner logic and the compaction logic. Both project should still implement how the coordination works, and in this PR, I've proposed something that might work for Thanos.

Verification

roystchiang avatar Jan 28 '22 17:01 roystchiang

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Apr 18 '22 23:04 stale[bot]

I believe this is still relevant

roystchiang avatar Apr 21 '22 16:04 roystchiang

Sorry for the delay. I hope we can continue this. Will do a another review next week.

yeya24 avatar May 28 '22 17:05 yeya24

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 21 '22 00:09 stale[bot]