thanos
thanos copied to clipboard
Store: Make initial sync more robust
I stumbled upon this during some tests - if the initial sync fails, this stops the whole initialization of a store and the process quits. The connection error might, however, be just ephemeral (e.g. the store is not ready yet or there was a temporary issue with the connection). It might be worthwhile to retry the initial sync in such cases, in order not to cause the process to exit directly after one failed attempt.
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind
command if you wish to be reminded at some point in future.
I think this is still valid
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind
command if you wish to be reminded at some point in future.
Hi! I can take this issue :)
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind
command if you wish to be reminded at some point in future.
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind
command if you wish to be reminded at some point in future.
Hi! Is this issue still valid?
I have raised a working PR against this issue :)
@matej-g if the PR fixes this issue, can we close this issue now with respect to the PR? :smile:
@Kartik-Garg yes please, thank you 🙇