thanos icon indicating copy to clipboard operation
thanos copied to clipboard

Store: Make initial sync more robust

Open matej-g opened this issue 3 years ago • 5 comments

I stumbled upon this during some tests - if the initial sync fails, this stops the whole initialization of a store and the process quits. The connection error might, however, be just ephemeral (e.g. the store is not ready yet or there was a temporary issue with the connection). It might be worthwhile to retry the initial sync in such cases, in order not to cause the process to exit directly after one failed attempt.

matej-g avatar Oct 28 '21 16:10 matej-g

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Jan 09 '22 02:01 stale[bot]

I think this is still valid

matej-g avatar Jan 10 '22 08:01 matej-g

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Apr 17 '22 04:04 stale[bot]

Hi! I can take this issue :)

shaoyi1997 avatar May 19 '22 09:05 shaoyi1997

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Jul 31 '22 04:07 stale[bot]

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Nov 13 '22 21:11 stale[bot]

Hi! Is this issue still valid?

PlytonRexus avatar Jan 09 '23 15:01 PlytonRexus

I have raised a working PR against this issue :)

Kartik-Garg avatar Jan 19 '23 09:01 Kartik-Garg

@matej-g if the PR fixes this issue, can we close this issue now with respect to the PR? :smile:

Kartik-Garg avatar Feb 22 '23 10:02 Kartik-Garg

@Kartik-Garg yes please, thank you 🙇

matej-g avatar Feb 22 '23 15:02 matej-g