thanos icon indicating copy to clipboard operation
thanos copied to clipboard

Add tests for IgnoreDeletionMarkFilter deadlock

Open kakkoyun opened this issue 4 years ago • 10 comments

The only test I can think of is a change detector that produces more errors than the level of concurrency. Can you think of anything else?

You could use a "fake" objstore.Bucket implementation which just returns errors and a number of blocks > concurrency. We expect the meta sync to deadlock (and so the test to timeout) in main branch while to return error in your PR. Does it make sense?

Originally posted by @pracucci in https://github.com/thanos-io/thanos/issues/4074#issuecomment-823029978

cc @zecke

kakkoyun avatar Apr 21 '21 08:04 kakkoyun

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Jun 20 '21 18:06 stale[bot]

Not stale

zecke avatar Jun 20 '21 23:06 zecke

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Aug 21 '21 03:08 stale[bot]

Not stale

zecke avatar Aug 28 '21 10:08 zecke

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Oct 30 '21 06:10 stale[bot]

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Jan 09 '22 02:01 stale[bot]

Not stale

zecke avatar Jan 09 '22 09:01 zecke

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Apr 17 '22 04:04 stale[bot]

Not stale

zecke avatar Apr 18 '22 05:04 zecke

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Sep 21 '22 02:09 stale[bot]