thanos
thanos copied to clipboard
thanos-io
Thanos UI Enhancements
The Thanos project has recently migrated its UI to one built on re-usable and shareable components written in React, with the goal of fostering collaboration with the broader Prometheus community. We would like to propose enhancements to the UI to better surface information in every Thanos component. This includes: exposing build- and run-time configuration; creating an API discovery page to provide living documentation of all of the endpoints exposed by Thanos components; and adding benchmarks for the UI. These enhancements all have the additional benefit of being relevant to and useful in the Prometheus project. As part of this proposal, we would like to further collaborate with the Prometheus community to continue building a shared UI component library and to contribute upstream to Prometheus so that it can leverage these components in its UI.
cc @thanos-io/thanos-maintainers cc @prmsrswt
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
Still valid. Wait for #3423 #3316 to get merged. cc @prmsrswt @Oghenebrume50
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
Hello there! I have experience with working in React, as this is marked as good first issue how can I contribute? Thanks.
Hello,
After doing a couple of PR to report the changes done on Prometheus side, in Thanos, definitely sharing component / service / pages would be great so we don't have to do the job twice.
On the prometheus point of view, it would be painful to put the different shared component outside of the Prometheus repository. So we could create one or multiple shared package in the Prometheus repository that then can be used directly in Prometheus without waiting for the release of each package (probably using the local path linked in the package.json of the react-app)
I think we could have something like that:
prometheus/prometheus
|
|
------ web/ui/shared
|
|
-------- package.json
|
|
-------- index.ts
|
|
------- services
| |
| |
| ----- prometheus.ts // http client that matches the prometheus API
|
-------- components
|
|
----- flag.ts // a page to display the flag
Regarding the versioning, we can release the package @prometheus/shared (didn't find better name) every 6 weeks when prometheus is released with the same version (currently v2.28)
WDYT @juliusv @onprem ?
/cc @bwplotka @roidelapluie
and not sure it's really a good first issue. But that's maybe just me haha.
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
On prometheus side we are starting to make some changes in the way the UI is managed.
We are currently looking at using the npm workspace. It will ease the usage of local npm package. We are starting with codemirror-promql.
Moving to npm workspace required many update and changes. It will take some times to have it in place. But once it is done, it will be probably interesting to create a new npm module that would be common between Prometheus and Thanos
The move to npm workspace is handled through this PR: https://github.com/prometheus/prometheus/pull/9227
We finally finished to move to the npm workspace on Prometheus side.
Probably it will make sense to start with https://github.com/thanos-io/thanos/issues/4685 in order to have a common module between Prometheus and thanos managing the PromQL expression
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
Closing for now as promised, let us know if you need this to be reopened! 🤗
I traced it until https://github.com/open-telemetry/wg-prometheus/issues/63 but I could use hints on what the next step would be today (cc: @Nexucis)
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
