objstore icon indicating copy to clipboard operation
objstore copied to clipboard

Some of the objstore operation duration metrics are 0

Open harry671003 opened this issue 2 years ago • 2 comments

The InstrumentedBucket doesn't emit duration metrics for Iter().

thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="0.001"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="0.01"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="0.1"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="0.3"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="0.6"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="1"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="3"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="6"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="9"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="20"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="30"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="60"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="90"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="120"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="+Inf"} 0
thanos_objstore_bucket_operation_duration_seconds_sum{bucket="",component="compactor",operation="iter"} 0
thanos_objstore_bucket_operation_duration_seconds_count{bucket="",component="compactor",operation="iter"} 0

https://github.com/thanos-io/objstore/blob/main/objstore.go#L487 Is this by design? I would like to measure the time taken for iterating the bucket.

harry671003 avatar Jun 13 '23 15:06 harry671003

Hi @harry671003, I would like to pick up this subject. Can you assign it to me?

ritaCanavarro avatar Aug 18 '23 11:08 ritaCanavarro

Sorry @ritaCanavarro, I didn't see this issue - I have filed #79 to fix it.

gotjosh avatar Sep 26 '23 14:09 gotjosh

I believe this issue has been solved. Closing now

yeya24 avatar Jul 24 '24 06:07 yeya24