objstore icon indicating copy to clipboard operation
objstore copied to clipboard
verified publisher icon thanos-io

download: dont cleanup directory after download failed

Open MichaHoffmann opened this issue 6 months ago • 1 comments

DownloadDir has the option to ignore paths that we have already on disk. In theory that makes downloads resumable, but in practice this doesnt work because we delete everything if one download fails. This means if one chunk in 1TiB block fails to download for whatever reason we start all over.

  • [ ] I added CHANGELOG entry for this change.
  • [ ] Change is not relevant to the end user.

Changes

Verification

MichaHoffmann avatar Jun 03 '25 13:06 MichaHoffmann

The Mimir team's feedback is positive BTW (as already communicated in Slack) :)

aknuds1 avatar Jun 13 '25 15:06 aknuds1