objstore icon indicating copy to clipboard operation
objstore copied to clipboard

client,providers: add storj DCS as provider option

Open stefanbenten opened this issue 2 years ago • 4 comments

  • [X] I added CHANGELOG entry for this change.
  • [ ] Change is not relevant to the end user.

Changes

  • Adding Storj Provider
  • Fixed import ordering for some touched files to make them consistent
  • Fixed some smaller items in the README.
  • Added the missing error checks in the cfggen script.

Verification

  • Compiled and ran it locally, worked fine.
  • Still working on adding the "Local Test Network" to ensure full functionality.

stefanbenten avatar Aug 07 '22 13:08 stefanbenten

I have practically no experience with storj, but one of the first things it says in the docs is that it’s S3 compatible, so I wonder what a direct integration does better than using the existing S3 integration?

brancz avatar Aug 08 '22 06:08 brancz

Hello @brancz, thank you for looking at this!

The native integration offers several advantages over the S3 compatible gateway. One of them being performance (cuts out the proxy/gateway) and the other important one being client side encryption rather than have it be done server side.

stefanbenten avatar Aug 08 '22 08:08 stefanbenten

This generally looks good to me. I wonder though if you'd be up for maintaining this, as if there are problems I don't think any of us have enough knowledge about Storj to be helpful in a meaningful way.

Would you be up for that?

brancz avatar Aug 18 '22 16:08 brancz

Thank you a lot @brancz !

I am more than happy to maintain the integration, let me know if there is anything further needed!

stefanbenten avatar Aug 18 '22 21:08 stefanbenten