bs-ant-design icon indicating copy to clipboard operation
bs-ant-design copied to clipboard

verify and merge additional bindings

Open Enalmada opened this issue 6 years ago • 0 comments

Following this project pattern I have added bindings for most of the remaining components here: https://github.com/Enalmada/bs-ant-design

These have not yet been used and since these were the first reason code I have ever done, many of them have incorrect callback types, need dynamic types (ie string | ReasonReact.reactElement), need to be tested, etc. Once I get around to that I will do a pull request. But they still might benefit someone in current state. If anyone reading this is able to double check them for errors and submit pull request that would be very helpful.

Design considerations I am converting list in reason code to array for proper javascript output. I think using lists in reason is nicer but let me know if this is a bad idea.

makeProps(
        ~actions=?Js.Option.map((. b) => Array.of_list(b), actions),

Note I have also gotten mobile web started: https://github.com/Enalmada/bs-ant-design-mobile

Enalmada avatar Oct 15 '18 17:10 Enalmada