Thane Thomson

Results 111 comments of Thane Thomson

> I was able to generate JSON structs (or Serialization types, as the issue calls it) from the OpenAPI definition in Tendermint Go. We need to decide how/where we want...

> Any advice you can give on the best way to do that in a greenfield capacity? Is there anything we can/should reuse from tendermint-rs? That's a tough one to...

See also #1128 for an additional complication :slightly_smiling_face: I've been thinking about this for a while now and it's still not totally obvious what the best possible solution here is....

Not sure why GitHub closed this issue.

> The little robots look for certain keywords The little robots are pretty dumb, because they missed the most important word in that sentence :smile:

This is most likely due to a legacy issue relating to serialization. The sane thing to do would be to replace all `Option` types with just `Hash`, since as you...

> When does the Hash type represent a secret value? Aren't they always computed over public chain data? Good question. What was the initial reasoning in having `ConstantTimeEq` implemented for...

No problem :slightly_smiling_face: I'll remove it. We can always add it back in future if it becomes apparent we're hashing sensitive data.

Actually, I'll keep this issue open until I've removed it.

At a high level this makes sense. I have some questions for clarification: 1. Would you like this option only for the `tendermint` crate, or are there any other crates...