ZurbInkBundle icon indicating copy to clipboard operation
ZurbInkBundle copied to clipboard

Active fork of this bundle, please contribute!

Open gremo opened this issue 6 years ago • 3 comments

This bundle is abandoned, see my fork.

This PR committed https://github.com/thampe/ZurbInkBundle/pull/26 breaks the inlining. Styles (even the foundation.min.css) should be added using zurb_ink_styles.add function, otherwise it doesn't work: CSS is not inlined and you have issues with Gmail and other clients stripping the <style> tag.

Solution (right now):

{% block headStyles %}
    {{ zurb_ink_styles.add('@HampeZurbInkBundle/Resources/public/css/foundation-for-emails/2/foundation.min.css') }}
    {{ zurb_ink_styles.add('your/custom/style.css') }}
{% endblock %}

Anyone interested in active maintain a fork of this bundle? Let me know!

gremo avatar Feb 15 '18 08:02 gremo

I'm going to active maintain my fork, please share your ideas and improvements here: https://github.com/gremo/ZurbInkBundle

gremo avatar Feb 15 '18 22:02 gremo

Great, I was also working on an active fork for this bundle as well! I just started yesterday and you already have more work done than me however. Were you working on https://github.com/thampe/inky also? I have made some updates to that also according to the latest changes on the main inky repo.

Emirii avatar Feb 20 '18 14:02 Emirii

Hi @Emirii, I'm happy to see that someone is interested in this my fork! Feel free to contribute to the fork with your ideas. I've done a bit of work and right now it's rewrited almost from scratch.

If you are working on inky that's great! I can move the dependecy to your repository. Push some work and let me see your improvements.

gremo avatar Feb 20 '18 15:02 gremo