time-to-leave icon indicating copy to clipboard operation
time-to-leave copied to clipboard

Cannot scroll down the window in calendar view / mode

Open timagixe opened this issue 2 years ago • 7 comments

Describe the issue When app is opened on month view, user cannot scroll the app when mouse is over the HH:MM input row.

To Reproduce Steps to reproduce the behavior:

  1. Go to Calendar view
  2. Change the window size to make scroll bar appear
  3. Hover mouse over hours and minutes input and try to scroll down
  4. The window won't scroll

Expected behavior The window is scrollable

Environment

  • Node/npm version: node 16
  • OS: latest mac os
  • TTL version: latest

Screenshots

https://user-images.githubusercontent.com/60817786/219939104-c130667e-114a-4e6b-ac41-845999920b46.mov

timagixe avatar Feb 19 '23 09:02 timagixe

This is intended behavior. Placing the mouse on lines turns the scroll wheel into horizontal scrolling. So one can see better when there are many entries.

araujoarthur0 avatar Feb 19 '23 13:02 araujoarthur0

I wonder if we could make it more dynamic though. Making it so the scrolling only changes when there is active content to scroll.

araujoarthur0 avatar Feb 19 '23 13:02 araujoarthur0

Or even do something like: switch to horizontal scrolling, but if it reaches the edges of horizontal scrolling (leftmost or rightmost scroll position) then start scrolling vertically.

tupaschoal avatar Feb 25 '23 10:02 tupaschoal

Hey! I think I've fixed the issue. Doing a pr right now

ellieliiii avatar Apr 23 '23 05:04 ellieliiii

Could you assign me to this? I tried to do a pr but didn't have permission

ellieliiii avatar Apr 23 '23 05:04 ellieliiii

You need to fork the repo and then do a PR. Only maintainers have rights to create branches and push directly on the repo.

tupaschoal avatar Apr 23 '23 11:04 tupaschoal

my bad, i've forked and made a pull request!

ellieliiii avatar Apr 23 '23 19:04 ellieliiii