time-to-leave icon indicating copy to clipboard operation
time-to-leave copied to clipboard

Published 20 hours ago • verified publisher icon thamara

Click on the notification should open TTL

Open thamara opened this issue 3 years ago • 5 comments

Clicking on the notification for "It's time to leave" should open the TTL app.

thamara avatar Nov 02 '21 02:11 thamara

Hi! Would you mind if I'm asking you to assign it to me? Me and my teammate would be glad to work on it.

And by the way, I'm waiting for the review of the PR #813 I requested 15 days ago. It would be nice if you leave a comment about it. Thanks!

haeramkeem avatar Nov 20 '21 12:11 haeramkeem

Sure, I've assigned it to you (and commented on the PR)

araujoarthur0 avatar Nov 20 '21 13:11 araujoarthur0

While working on this issue, I've got an error $ is not defined in js/notification.js. I think using jquery in notifyTimeToLeave() causes this problem because js/notification.js runs in main process, not in renderer process. Have any idea how to fix this?

haeramkeem avatar Dec 05 '21 15:12 haeramkeem

I have never faced this, any idea @araujoarthur0 ?

tupaschoal avatar Dec 07 '21 02:12 tupaschoal

This appears to already be correct on MacOS. @Thamara Are you using Windows?

Atomic-Germ avatar Feb 28 '22 19:02 Atomic-Germ

Maybe you could assign this to me so no one else work on it?

ochan12 avatar Nov 24 '22 22:11 ochan12

Hello @ochan12, are you still working on this?

EDIT: Oops, my bad, just saw the open PR.

tupaschoal avatar Dec 08 '22 11:12 tupaschoal