time-to-leave
time-to-leave copied to clipboard
Changelog update workflow should push to PR branch instead of main
We have a workflow to update the changelog upon a comment in PRs matching a given message.
The comment looks like:
\changelog-update
Message: Enhancement/Fix: Some message
User: some_user
Upon triggered, it will commit on the main
branch with the new changelog addition. This is not ideal as we technically update the changelog before actually merging the content (we could do it later too, but the point is that they are separate actions).
The goal here is to push this changelog change on the branch of the PR itself, so that they are merged together as one, and the process becomes a bit more atomic.
Hi @tupaschoal, Is this in-progress already? If not, I would like to work on this.
Assignee it to you;)!
I'm reopening this issue as we are having problems with committing to the branch on the PR. Among the issues, I'm seeing:
- Different errors on permissions (when user haven't specified that it allows changes from the maintainers). Example: #739
- Commits to the branch that don't show up in the PR. Example: #754
The second issue is most likely something on the git push command, but for the first one we need a better solution.
I have backed-out the relevant part of this change in this commit until we have a more robust solution.
@BhumikaSaini I'm removing you as assignee as this has been changing from the initial proposal. But if you have any suggestions, or want to work on it, please let me know.
Sure @thamara, I will let you know if I find a solution for this. Thank you!
For the future: To test, reopen PRs #741 and #739
Droping this for now. Although not ideal, dealing with adding commits to others PR is quite complicated. :(