time-to-leave icon indicating copy to clipboard operation
time-to-leave copied to clipboard

Changelog update workflow should push to PR branch instead of main

Open tupaschoal opened this issue 3 years ago • 5 comments

We have a workflow to update the changelog upon a comment in PRs matching a given message.

The comment looks like:

\changelog-update
Message: Enhancement/Fix: Some message
User: some_user

Upon triggered, it will commit on the main branch with the new changelog addition. This is not ideal as we technically update the changelog before actually merging the content (we could do it later too, but the point is that they are separate actions).

The goal here is to push this changelog change on the branch of the PR itself, so that they are merged together as one, and the process becomes a bit more atomic.

tupaschoal avatar Oct 08 '21 11:10 tupaschoal

Hi @tupaschoal, Is this in-progress already? If not, I would like to work on this.

BhumikaSaini avatar Oct 09 '21 10:10 BhumikaSaini

Assignee it to you;)!

tupaschoal avatar Oct 09 '21 10:10 tupaschoal

I'm reopening this issue as we are having problems with committing to the branch on the PR. Among the issues, I'm seeing:

  • Different errors on permissions (when user haven't specified that it allows changes from the maintainers). Example: #739
  • Commits to the branch that don't show up in the PR. Example: #754

The second issue is most likely something on the git push command, but for the first one we need a better solution.

I have backed-out the relevant part of this change in this commit until we have a more robust solution.

@BhumikaSaini I'm removing you as assignee as this has been changing from the initial proposal. But if you have any suggestions, or want to work on it, please let me know.

thamara avatar Oct 14 '21 05:10 thamara

Sure @thamara, I will let you know if I find a solution for this. Thank you!

BhumikaSaini avatar Oct 16 '21 16:10 BhumikaSaini

For the future: To test, reopen PRs #741 and #739

thamara avatar Oct 17 '21 04:10 thamara

Droping this for now. Although not ideal, dealing with adding commits to others PR is quite complicated. :(

thamara avatar Oct 17 '22 00:10 thamara