pydoll icon indicating copy to clipboard operation
pydoll copied to clipboard

[Feature Request]: Pass quality argument to get_screenshot method

Open Airmask1 opened this issue 8 months ago • 1 comments

Checklist before requesting

  • [x] I have searched for similar feature requests and didn't find a duplicate.
  • [x] I have checked the documentation to confirm this feature doesn't already exist.

Problem Statement

def screenshot( cls, fmt: str = 'jpeg', quality: int = 100, clip: dict = None ) -> dict: The class method have quality argument (in case someone like me want to use it), but you should expand the whole class and pass Page to browser which is little bit unnecessary.

Proposed Solution

Maybe just add argument to: async def get_screenshot(self, path: str) method which executes screenshot class method under the hood ?

Alternatives Considered

No response

Additional Context

No response

Importance

Nice to have

Contribution

None

Airmask1 avatar Apr 29 '25 08:04 Airmask1

Hi @Airmask1,

Thanks for the suggestion! This is already being worked on in the new version of Pydoll, which will be released soon. Below there is a preview

Image

thalissonvs avatar May 01 '25 04:05 thalissonvs

@Airmask1 Hi! I just released a new version. Just install the new version, this feature is already available :)

thalissonvs avatar Jun 08 '25 03:06 thalissonvs

@Airmask1 Hi! I just released a new version. Just install the new version, this feature is already available :)

Thanks a lot, already upgraded.

Airmask1 avatar Jun 13 '25 11:06 Airmask1