Thales

Results 60 comments of Thales

The `rf_channel` field is actually checked in `Addresses::new`, and other code relies on that. So, we can't just make the fields public.

If your problem is with HTTP/2 then you would want to tune at a lower level, namely: https://docs.rs/h2/0.4.12/h2/server/struct.Builder.html#method.initial_connection_window_size and https://docs.rs/h2/0.4.12/h2/server/struct.Builder.html#method.initial_window_size This isn't currently exposed though, so you would need to...

`load_link` sets a flag and `store_conditional` clears it on the successful path. So, in my example, the second thread would have a successful `store_conditional` while the first one would fail....

I think even `as_ref` for `UnionNode` is unsound under stack borrows. I was working into getting some loom + miri support for heapless. My idea is to have a PR...

Why all the function docs start with: `Internal function (...)`? If it's because the functions used to be `pub(crate)`, then the text should be updated.

This doesn't seem like a proper fix. The client might have closed its writer side of the connection with a FIN, but still want to receive the response. That's was...

@bitcapybara Your program was supposed to detect the EOF on the read stream indeed, but this is different from some of the complains in #1313, where people were referring to...

Thanks for taking the time to investigate and create this PR. We will have to also add a Drop implementation with `assume_init_drop`. I guess this is also non-breaking, since I...

Isn't the returned value only used for one verification? i.e. the function is called on every handshake, making it possible to change the values per handshake, no?

CC @adamgreig Since this is replacing a previous PR from you.