Sebastiaan van Stijn
Sebastiaan van Stijn
Thanks for the update!
@kolyshkin do you think we should reopen this ticket for tracking ("remove the workaround once we can"?)
(This is expected to fail on go1.15 in ci)
I'm a big fan of `//go:embed` already. The only thing I'm missing is an option to compress the embedded files (at least, I don't think the embedded files are optimised...
@kolyshkin @cyphar @AkihiroSuda ptal; I moved this one out of draft, now that we dropped Go < 1.16 on the master/main branch. Given that this only affects the _binary_ (i.e.,...
oh! good catch. hmm I guess the VERSION file has a newline; we could remove it there, or when printing 🤔
Yes, I was a bit in doubt if the string would be used elsewhere, but I guess it's only for printing, and in that case trimming it seems indeed a...
Oh! Let me reply here as well on @tianon's comment (thanks!). So it turned out we were both looking at "how to use the go1.18 features" for the remaining bits;...
If we switch to using the "local" format (i.e., use 3 groups: "stdlib", "external imports", "local imports"), we should probably add a check in CI (and possibly a makefile target)...
> It might be clearer to separate the reference packages. I don't disagree, but if we make this change, we should consider having a check in CI, and a make...