Sebastiaan van Stijn

Oh! Actually wanted to comment about that, but forgot; > restarting a job will always re-run the same YAML as the original run (and there's nothing something like actions/checkout can...

Remaining linting issues; ``` Error: exported type `KeySerial` should have comment or be unexported (golint) Error: exported function `JoinSessionKeyring` should have comment or be unexported (golint) Error: exported const Wildcard...

Remaining ones: To discuss: (rename or add `nolint` comments?) libcontainer/user/lookup_unix.go:31:6: var-naming: func LookupUid should be LookupUID (revive) libcontainer/user/user.go:30:2: var-naming: struct field Uid should be UID (revive) libcontainer/user/user.go:214:2: var-naming: struct field...

@kolyshkin (forgot to ping you); last commit is a quick renamed of variables to the correct capitalisation. There's some inconsistency in `CRIU` vs `Criu` (looks like the CRIU sdk itself...

The first commit still has this paragraph in the commit message, which no longer appears to be the case; > Remove logrus setup and use from TestMain/init, in preparation for...

Oh! Interesting that they improved that; good to know!

> Mapping settings makes some sense, but completely ignoring them when they've been explicitly set by a user is a completely different thing. At least it should produce a warning...

Also wondering how `oom_score_adj` should be mapped if it's per-process instead of cgroup; if a container has multiple processes, _some_ of those could get OOM-killed, instead of the container as...

So (without having given it a _huge_ amount of thought) I'm a bit on the fence if it's a good thing to implement this as a generic `DeepCopy()` utility; I...

Looks like this was opened from a branch that was outdated; can you try rebasing your branch to get rid of the unrelated commits?