react-native-safe-area-context
react-native-safe-area-context copied to clipboard
False notch auto detect on "hideable" android menu. Bottom tab bar has like double size in height with react-navigation
Hi, I've installed last versions of react-navigation and react-native-safe-area-context, and we have an issue with Android bottom navigator. This behavior is occurring, at least on my phone (Asus Zenfone 5), and pretty sure in other that have that choice. In previous versions worked fine, that's mean, the bottom tab navigator goes up and down whit Android's navigation bar, isn't static like now with double height. I'm attaching a gif, the code is exactly the same and was taken of example of react navigation tabs (copy paste) from here: https://reactnavigation.org/docs/bottom-tab-navigator last snack example link. I've opened an issue days ago in react-navigation, but they told me that I have to open an issue here.
Thanks in advance.
I am having the same issue with Samsung S8
Same issue
changing from getSystemWindowInsetBottom to getStableInsetBottom seems to have been the problem which was applied between version 1.0.3 and 2.0.0 in the SafeAreaUtils.java
Any news? Can't make it work. Thanks again.
@Meinl you can use my fork in the meantime if you want. I reverted it back to using getSystemWindowInsetBottom which seemed to do the trick.
https://github.com/CDBridger/react-native-safe-area-context
Interesting, I changed to getStableInsetBottom
because getSystemWindowInsetBottom
would change when the soft keyboard opens, which we don't want to match the iOS behavior. I didn't some android devices hide the navbar like this. I can probably use Math.min(getSystemWindowInsetBottom(), getStableInsetBottom())
instead.
Could you check if version 3.1.6 fixes the issue?
Could you check if version 3.1.6 fixes the issue?
I've updated to ^3.1.6 but not work. I assume because I'm using expo and I've checked expo dependencies in yarn.lock file and it's using ~3.0.7 version. I don't how to test it, can you help me? Thanks.
The fix is in native code so sadly it won't work until expo updates this dependency. I think you'd have to eject to be able to update now.
Same Problem here even after updating to 3.1.7 on an ejected project (not expo). Even if android navigation is hidden, the bottom insets are applied.
@janicduplessis it does not work.
Any updates on this issue? Is there a fix expected in the foreseeable future? Does anybody know if it affects other devices? I've noticed it on a Samsung S8 too.
This is for v3 of the library, and we're on v4. Please re-open a new issue if you're still facing issues