Stefan Hammer

Results 54 comments of Stefan Hammer

@loicteixeira epic work, this really improves the quality of wagtail's i18n! I've focused on the changed translation calls in python and the resulting strings (original and "de"), I've also tested...

After finding the missed replacement above, I've searched through all resulting po files. I did not find any other (missed) "%s" strings, but after searching for "{", I've found the...

Awesome! > The rule only looks for Python files. I'll have a look at enabling it for js/jsx/ts/tsx files as well, but I'll need to make sure it doesn't break...

Should we add `semgrep --config .semgrep.yml --error` also to the Makefile's `lint-server` section? The PR's template guides everyone to execute `make lint`, so this would then also cover semgrep. I...

Big :+1: @loicteixeira After your changes, I've now tried a different approach: I've executed your replacement script, then I've used a modified version of "rebuild-translation-sources.sh" (using "de" instead of "en",...

Maybe a little bit late, because I think the whole thing gets quite solid with the next iteration, but we could use [github-gists](https://gist.github.com) for the replacement script, so reviewing changes...

@elton2048 you can close this PR, since it is already merged and released with #35 (1.1.0)

The failing tests took me a while, but they lead me to an issue where the user's timezone is leaked into following requests. More detailed: For my new tests above...

@laymonage awesome, thx for your effort, and I totally understand any hesitation here! :+1: > Hopefully this doesn't break anything, as the decorator is basically applied to all of Wagtail's...

+1 We hardly ever use plain `TextField`s, instead we use `RichtTextField`s with limited features, so having no blocks is quite common for us, which also resulted in some bug reports...