Gokhan

Results 46 comments of Gokhan

> Please rebase and sign. See https://github.com/prometheus/alertmanager/pull/3638/checks?check_run_id=21162278935 I followed the instructions on the link you shared, please let me know if there is anything else I need to do 💐

> @th0th I don't think you rebased correctly as there are now 73 commits in this PR. Did you use `git rebase`? You also still need to sign off all...

> You can squash all the commits into a single commit using `git rebase` and then sign the commit using `git commit --amend --no-edit --signoff`. > > Another option is...

> > I rebased, and it reduced the number of commits but there are still some commits that are shown in this PR, but not mine. No idea why. >...

> Hi @th0th! 👋 Do you need help with the rebase? I do indeed 🙃

> OK. I ran the following: > > ``` > git fetch > git rebase origin/main // here origin is [email protected]:prometheus/alertmanager.git > git rebase -i HEAD~16 > ``` > >...

> > What am I doing wrong? :( > > You should be able to edit what is there when you run `git rebase -i HEAD~16` – you don't need...

Thanks for the help getting this merged folks :) @grobinson-grafana I would love to test, but I am using grafana right now, and I don't have alertmanager running separately :(

@levic can you please share your `camelize` with ignore implementation? I have the same issue, with a `JSONField`. However, I am not sure that setting a global ignore pattern would...