youtube-music Support MPRIS loop and volume change

Support MPRIS loop and volume change

Open foonathan opened this issue 2 years ago • 9 comments

This PR supports MPRIS loop status on linux, enabling playerctl loop to fetch and playerctl loop None/Track/Playlist to set.

Jun 14 '22 13:06 foonathan

LGTM (but can't personally test it since I don't have access to Linux currently)

Jun 14 '22 17:06 Araxeus

Anything I could do to help it get merged?

Jun 14 '22 20:06 foonathan

@th-ch

Jun 14 '22 20:06 Araxeus

I've just pushed another fix for a bug when using playerctl play-pause.

Jun 22 '22 16:06 foonathan

In javascript we always use === instead of == 😋

(and !== instead of !=)

could you change those?

Jun 22 '22 17:06 Araxeus

I've changed it. Do you want me to clean up the commits and force push?

Jun 26 '22 15:06 foonathan

you should also change it in plugins/shortcuts/mpris.js lines 43-45-47

Jun 26 '22 15:06 Araxeus

Volume change support is now implemented as well.

Jul 11 '22 18:07 foonathan

Can this be merged?

Jul 26 '22 07:07 foonathan