Thomas Gummerer
Thomas Gummerer
Docs for how this GitHub feature works: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
> Since `defaultProviders` seems to allow side-by-side versions, why aren't the explicit providers handled in this same way? They are. We do allow side-by-side versions here, and I think that's...
https://github.com/pulumi/pulumi/actions/runs/8940715790/job/24559696851?pr=16117 shows the output.
> Nice find. I think we might want https://github.com/pulumi/pulumi/pull/16116 as well if stdout/stderr logs are big. Yeah I don't mind having that merged as well. We shouldn't need that output...
Looking at the failure in the merge queue here, this doesn't quite do what we want unfortunately. I had another look at the test output, and I think https://github.com/pulumi/pulumi/pull/16117 will...
This might potentially be related to https://github.com/pulumi/pulumi/issues/6768 as well.
I opened a couple of issues for the tests that were flaking here: https://github.com/pulumi/pulumi/issues/15965 and https://github.com/pulumi/pulumi/issues/15964. We need to fix those _before_ we merge this.
No worries, happy to review when it is ready!
I wonder if there's scope for completing @julienp's "Publish junit results" here as well (https://github.com/pulumi/pulumi/pull/15465). It seems somewhat useful to have this information as a PR comment.
@fitz-vivodyne Thanks for the PR and sorry about the delay here. I've just let the tests run, and there are some failures. I believe this has the same cause as...