tgstation icon indicating copy to clipboard operation
tgstation copied to clipboard

General maintenance for file cabinets

Open JohnFulpWillard opened this issue 1 year ago • 1 comments

About The Pull Request

This PR brings more modern code standards to filing cabinets as it has bugged me for a while, including balloon alerts.

replaces initial(icon_state) with base_icon_state uses wrench_secondary instead of checking modifiers for right click and attacking with a wrench removes check for ishuman to add someone to the file cabinet, anyone on the manifest should be added to the record list. replaces to-chat with balloon alert, though I removed the one saying 'you inserted [thing] into the cabinet' because it was quite useless, you know what you are adding since it is in your hand, and the icon state changing is enough feedback to the player of the action they did. adds autodoc removes copypaste 'virgin' var, replaced with a populated var on the base file cabinet that they all use. replaces camelCase and single-letter vars removes a sleep

Why It's Good For The Game

General maintenance for yet another pretty old part of the codebase, god rest their soul.

Changelog

:cl: qol: File cabinets now use balloon alerts instead of messages to your chat. /:cl:

JohnFulpWillard avatar Feb 13 '24 15:02 JohnFulpWillard

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

github-actions[bot] avatar Feb 21 '24 00:02 github-actions[bot]