tgstation icon indicating copy to clipboard operation
tgstation copied to clipboard

Add Admin Fax System

Open twilightwanderer opened this issue 3 years ago • 6 comments

About The Pull Request

Thanks to @kawoppi for giving me the opportunity to finish my implementation.

From the moment I put the fax functionality in the build, I planned the implementation of this system. The only reason I didn't do it right away was because I wanted to see how relevant the fax mechanics would be in the build. And now I'm ready to present my implementation of a fax messaging system similar to the Requests Manager system.

изображение

изображение

изображение

Why It's Good For The Game

With this system, players will be able to send messages to a specially generated list of virtual faxes when accessed or hacked, and administrators will be able to read messages and send responses.

Changelog

:cl: add: Ability to send and receive administrator fax messages. admin: Panel for easy viewing and sending messages to faxes. /:cl:

twilightwanderer avatar Sep 22 '22 11:09 twilightwanderer

You currently have a negative Fix/Feature pull request delta of -8. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

github-actions[bot] avatar Sep 22 '22 11:09 github-actions[bot]

The CC and Syndicate colors look extremely offensive, could you tone them back a bit? Clown Planet too but yellow is.. a color.

Jolly-66 avatar Sep 22 '22 11:09 Jolly-66

The CC and Syndicate colors look extremely offensive, could you tone them back a bit? Clown Planet too but yellow is.. a color.

Correction, this is an example showing that TG-based assemblies can set their own list of faxes.

twilightwanderer avatar Sep 22 '22 11:09 twilightwanderer

The CC and Syndicate colors look extremely offensive, could you tone them back a bit? Clown Planet too but yellow is.. a color.

Correction, this is an example showing that TG-based assemblies can set their own list of faxes.

White text on neon bright color. 💀

Miczu555PL avatar Sep 22 '22 12:09 Miczu555PL

If I'm understanding that second screenshot correctly you can write faxes with the menu, that's really useful! Does it also allow you to use paper markdown when writing a fax that way?

kawoppi avatar Sep 22 '22 12:09 kawoppi

If I'm understanding that second screenshot correctly you can write faxes with the menu, that's really useful! Does it also allow you to use paper markdown when writing a fax that way?

Yes. The paper is based on plain HTML. I originally tried to do a preview, but I couldn't beat the FPS sagging.

twilightwanderer avatar Sep 22 '22 13:09 twilightwanderer

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

github-actions[bot] avatar Oct 09 '22 00:10 github-actions[bot]

I still don't understand why players need to be restricted in this way.

twilightwanderer avatar Oct 11 '22 07:10 twilightwanderer