tgstation icon indicating copy to clipboard operation
tgstation copied to clipboard

Fax Machine

Open twilightwanderer opened this issue 3 years ago • 27 comments

About The Pull Request

Now that the mechanics of paperwork are working again, you can get busy improving the bureaucratic stuff. In many SS13 builds there is a fax machine. A handy thing to send papers from one part of the station to another. So I decided to develop a fax machine specifically for tgstation.

1

The mechanics are simple - stick the paper in and send it to the addressee from the list of available faxes.

HJLZcAIekB

I'll answer the probable question right away. This fax machine, unlike modern fax machines, does not copy paper images, but teleports them obviously by means of bluespace magic. This will open up funny situations with teleporting paper to the wrong addressee. I also did not envision recreating a fax using the boards, because I am afraid people will start abusing it. I foresee that by default each department will have one fax for the crew and one for the head.

dreamseeker_Dp7wM8STHD

For Mappers: Fax is self-sufficient and assigns itself the necessary variables required for its work. But for full use, you need to fill in the following fields:

  • fax_name - displays the fax name in the fax list.
  • syndicate_network - Indicates that the fax belongs to an enemy network and does not show in the general list.

Naturally, I created functions for traitors. Fax can be hacked. Then it will have the ability to display hidden faxes from the syndicate network and rename the fax with the multitool names of other faxes. For example to the name "fax captain". It would be funny to see two faxes with that name and not know which one to send the paper to.

Why It's Good For The Game

I've talked to a lot of people and many have expressed a desire to see faxes in the game, reasoning that they would increase crew involvement in dealing with the bureaucracy.

Changelog

:cl: add: Fax Machine /:cl:

twilightwanderer avatar Aug 08 '22 18:08 twilightwanderer

You currently have a negative Fix/Feature pull request delta of -8. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

github-actions[bot] avatar Aug 08 '22 18:08 github-actions[bot]

Please tell me it makes this sound every time it sends or receives a fax https://youtu.be/qTX1lI8COuQ

Farquaar avatar Aug 08 '22 20:08 Farquaar

https://user-images.githubusercontent.com/47086570/183509188-17bc0660-b844-4afb-ac60-34bd3440ac90.mp4

IndieanaJones avatar Aug 08 '22 20:08 IndieanaJones

Will you consider making it possible to send faxes to the various parts of NanoTrasen CC, or even other station captain faxes? I know communication console already does that, but the fax can make it so admins can reward people for putting their hard effort into making a document, instead of just writing one simple message.

We can probably make it like in Baystation, where fax is used for more casual messages, and the communication consoles is for emergencies only.

DrDiasyl avatar Aug 08 '22 21:08 DrDiasyl

Will you consider making it possible to send faxes to the various parts of NanoTrasen CC, or even other station captain faxes? I know communication console already does that, but the fax can make it so admins can reward people for putting their hard effort into making a document, instead of just writing one simple message.

We can probably make it like in Baystation, where fax is used for more casual messages, and the communication consoles is for emergencies only.

Oh and expanding this. This will also make more possibilities for traitor gimmicks with the chamelon stamp masked as CC stamp. We can also probably make a entire paperwork faking kit with the special pen which can fake SIGNS (Just like in Baystation)

DrDiasyl avatar Aug 08 '22 21:08 DrDiasyl

I don't see map changes at the moment, but if you plan on adding them in-game, definitely make sure lawyer and psychologists have one

JohnFulpWillard avatar Aug 08 '22 21:08 JohnFulpWillard

Would it be possible to fax mail?

ArcaneMusic avatar Aug 08 '22 21:08 ArcaneMusic

someone please add cross server faxing kthanx and bye

optimumtact avatar Aug 08 '22 21:08 optimumtact

So hypothetically if someone put c-4 or x-4 on a piece of paper and faxed the paper over, would it stay on the paper?

Bluedino1025 avatar Aug 09 '22 00:08 Bluedino1025

So hypothetically if someone put c-4 or x-4 on a piece of paper and faxed the paper over, would it stay on the paper?

we're taking mailing people pipe bombs to a new era (the 80s)

Zonespace27 avatar Aug 09 '22 01:08 Zonespace27

Would it be possible to fax mail?

I could add such mechanics, but I'm afraid it would make the mechanics very easy for the delivery guys.

twilightwanderer avatar Aug 09 '22 05:08 twilightwanderer

I don't see map changes at the moment, but if you plan on adding them in-game, definitely make sure lawyer and psychologists have one

I won't put them on the map until everything is ready and approved.

twilightwanderer avatar Aug 09 '22 05:08 twilightwanderer

Will you consider making it possible to send faxes to the various parts of NanoTrasen CC, or even other station captain faxes? I know communication console already does that, but the fax can make it so admins can reward people for putting their hard effort into making a document, instead of just writing one simple message.

We can probably make it like in Baystation, where fax is used for more casual messages, and the communication consoles is for emergencies only.

At this stage of development it is easy enough to do. It is enough to place a fax so that other faxes will see it.

twilightwanderer avatar Aug 09 '22 05:08 twilightwanderer

My advice is that this PR is already a decent change on it's own, I'd recommend any follow ups come in the form of a new PR

optimumtact avatar Aug 09 '22 06:08 optimumtact

My advice is that this PR is already a decent change on it's own, I'd recommend any follow ups come in the form of a new PR

Yes, of course I will not develop in this PR any other functionality than a fax machine.

twilightwanderer avatar Aug 09 '22 07:08 twilightwanderer

So hypothetically if someone put c-4 or x-4 on a piece of paper and faxed the paper over, would it stay on the paper?

It seems like it does.

ghost avatar Aug 09 '22 07:08 ghost

I have tried to improve the code and therefore reopen the PR.

twilightwanderer avatar Aug 09 '22 15:08 twilightwanderer

I have tried to improve the code and therefore reopen the PR.

No need to explain yourself, you mark it ready when you think it's ready, we'll draft if it isn't after.

JohnFulpWillard avatar Aug 09 '22 15:08 JohnFulpWillard

In my opinion the sprite's a bit dull, color-wise. Maybe I'm just too used to shiny things but I do feel at least some parts of it could look a bit brighter, like those buttons and screen

Wallemations avatar Aug 10 '22 03:08 Wallemations

If the next review shows that everything is fine, I will start putting faxes on the maps.

twilightwanderer avatar Aug 10 '22 09:08 twilightwanderer

In my opinion the sprite's a bit dull, color-wise. Maybe I'm just too used to shiny things but I do feel at least some parts of it could look a bit brighter, like those buttons and screen

I admit that I'm not the best spriter. At least I tried to keep the color palette like a photocopier to give the general style of office equipment.

twilightwanderer avatar Aug 10 '22 09:08 twilightwanderer

mapping stuff would be for maptainers, code stuff is fine though.

Thank you for your review.

twilightwanderer avatar Aug 10 '22 11:08 twilightwanderer

Kilo is a pain. I wanted to quit halfway through and not try to add faxes to Kilo, but by some miracle I did. Except for the service and QM faxes.

twilightwanderer avatar Aug 10 '22 17:08 twilightwanderer

Kilo is a pain. I wanted to quit halfway through and not try to add faxes to Kilo, but by some miracle I did. Except for the service and QM faxes.

What's wrong?

DrDiasyl avatar Aug 10 '22 17:08 DrDiasyl

What's wrong?

When inserting faxes, I try to keep everything in its original form. At most, I move things to other places. Here's an example of a QM office. It's just not realistic to put a fax in here.

изображение

twilightwanderer avatar Aug 10 '22 17:08 twilightwanderer

I finished arranging the faxes on the maps. I tried not to change anything in the interiors of the rooms or remove personal belongings, only moved.

twilightwanderer avatar Aug 10 '22 18:08 twilightwanderer

What's wrong?

When inserting faxes, I try to keep everything in its original form. At most, I move things to other places. Here's an example of a QM office. It's just not realistic to put a fax in here.

изображение

Holy shit, this is packed.

DrDiasyl avatar Aug 10 '22 19:08 DrDiasyl

Your Fix/Feature pull request is currently below zero (-11). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions[bot] avatar Aug 12 '22 16:08 github-actions[bot]