TerraGov-Marine-Corps
TerraGov-Marine-Corps copied to clipboard
tgstation
Acid smoke now checks for Acid protection instead of bio protection.
About The Pull Request
Makes smoke_contact check for acid soft and hard protection whenever dealing acid damage instead of permeability Optimizes get_permeability_protection
Why It's Good For The Game
Biological protection should apply to biological sources , acid protection to acid sources.
Changelog
:cl: code: Optimized get_permeability_protection() balance: Xeno smoke now checks for acid protection(both soft and hard) whenever dealing burn damage (from XENO_SMOKE_ACID sources) instead of bio. /:cl:
This is a "stealth" mimir nerf since you are moving smoke effects from the variable it negates onto other defense categories.
Should I ask why this PR is phrased in this particular way, instead of even mentioning mimir anywhere in the PR body, despite you editing the item descriptions having clearly considered this effect?
I rephrased the description so the change is visible on the mimir , if i wanted this to be a "stealth" change i would've never rewritten the mimir description to reflect the change.
Not to mention this BUFFS marine protection in general against acid. Normal armor only had 20% , now since it takes acid into account , the minimum is 35% up to 55%.
This is a "stealth" mimir nerf since you are moving smoke effects from the variable it negates onto other defense categories. Should I ask why this PR is phrased in this particular way, instead of even mentioning mimir anywhere in the PR body, despite you editing the item descriptions having clearly considered this effect?
I rephrased the description so the change is visible on the mimir , if i wanted this to be a "stealth" change i would've never rewritten the mimir description to reflect the change. Not to mention this BUFFS marine protection in general against acid. Normal armor only had 20% , now since it takes acid into account , the minimum is 35% up to 55%.
i don't believe you, also you didn't put it in the PR body, that's why we think of it as a stealth nerf. Adding onto this, acid protection should be applied on TOP of bio protection, as acid should only affect you if it can get through your armor.
