TerraGov-Marine-Corps
TerraGov-Marine-Corps copied to clipboard
tgstation
Datumizes storage
About The Pull Request
Turns storage into a datum instead of hard coding it onto item/storage
Why It's Good For The Game
Storage datums are more robust than hardcoding it onto a typepath
Changelog
:cl: refactor: Storage refactor /:cl:
I cant wait for this to cause thirty inexplicable bugs that you spend another year chasing down like Lumi and his throws
I cant wait for this to cause thirty inexplicable bugs that you spend another year chasing down like Lumi and his throws
Nah I'd win
if you are going to port stuff actually port it and stop trying to ignore the port ban
As discussed align it as close to tg as reasonable, ping me when you want this reviewed
sooo on the test merge of this pr the current bugs I personally found where: empty containers including flare pouches and all med pill bottles you cant take out pill bottles from backpacks you cant quick pull pills and other objects via using alt-click(again tested on pill bottles)
Bypassing checks on pill bottle contents isn't going to let people make infinite RR pills or something, right?
Bypassing checks on pill bottle contents isn't going to let people make infinite RR pills or something, right?
RR Pills are gone + you can't restock them anyways so? Keeping in mind, loadout vendor literally buys items from the vendors, so RR in the vendor (if it exists) would run out at the normal rate wether you vend it by hand or via loadout.
Please elaborate on why this is good for the game
It is code quality. Allows to decouple storage, so everything can easily become one without having to do shitcode
We did it chat. Special thanks to anyone who helped by bug reporting during the test merges :D