TerraGov-Marine-Corps icon indicating copy to clipboard operation
TerraGov-Marine-Corps copied to clipboard

Orbit UI rework: Adds icons, health bars, better view.

Open jlsnow301 opened this issue 2 years ago • 8 comments

About The Pull Request

Reworks the orbit UI to be quite a bit more interactive. Could probably use TM'd, it's hard to test every icon and case.

This PR adds:

  • Health-colored buttons
  • Xeno nickname buttons
  • Section colors
  • Collapsible sections
  • Job info
  • Job icons
  • Search by caste/job

nRQx9YjLzz

Why It's Good For The Game

Better observer experience. Adds funny names, icons, health bars.

Changelog

:cl: qol: Reworks the Orbit UI to be much more interactive. Colors buttons on health, collapsible sections, job icons, and more. /:cl:

jlsnow301 avatar Oct 24 '22 00:10 jlsnow301

Nice

Lumipharon avatar Oct 24 '22 00:10 Lumipharon

Test Merge Deployed

Server Instance

TGMC

Merged By

Lewdcifer

Revision

Origin: ba11e493e0e54387094b1aee3f723c962e51dc58 Pull Request: 4a57043ed16d43c6dd2da15e2884556c93fb0a3d Server: 0a3ec3bd7c91e04d1af2ffa9788b52e05723e2f5

Comment

comfyorange avatar Oct 25 '22 16:10 comfyorange

Beautiful update, love what you did here.

Just here to report a bug, though; image There's currently a bug where the orbit UI will show all of these icons in the Marines tab.

lKiseki avatar Oct 25 '22 17:10 lKiseki

There's currently a bug where the orbit UI will show all of these icons in the Marines tab.

lol, nice, on it right now

Screenshot 2022-10-25 105403

jlsnow301 avatar Oct 25 '22 17:10 jlsnow301

Test Merge Removed

comfyorange avatar Oct 25 '22 19:10 comfyorange

Should be safe to put on TM again.

jlsnow301 avatar Oct 25 '22 21:10 jlsnow301

Does this fix #11049?

Edelor68 avatar Oct 26 '22 11:10 Edelor68

Does this fix #11049?

i don't think so, the underlying issue there seems that they get categorized as NPCs or something (mind == null). i will test it and report the results.

jlsnow301 avatar Oct 26 '22 16:10 jlsnow301

Test Merge Deployed

Server Instance

TGMC

Merged By

Lewdcifer

Revision

Origin: de3c2c8ebf8e37758d277c25b7907d8059064f00 Pull Request: e3d723deb37eb08ac9d44567914a3a87023f4f1b Server: 54f6b1801c5e375491da3123d1bedf3c5c653b16

Comment

GitHub Deployments

comfyorange avatar Oct 27 '22 15:10 comfyorange

Disabling Auto-observe does not unobserve the selected target. Whereas before, you disable auto-observe to disable spectating the person and their inventory.

You can still disable spectating the person by orbiting another target while auto-observe is off, which is weird.

XSlayer300 avatar Oct 29 '22 00:10 XSlayer300

Test Merge Updated

Server Instance

TGMC

Merged By

Lewdcifer

Revision

Origin: 74ddc18f3425d2a813310b95d0a2e0f96909bce9 Pull Request: e3d723deb37eb08ac9d44567914a3a87023f4f1b Server: 0630093ff9a7e29366983fccc1d30b0735259a83

Comment

comfyorange avatar Oct 29 '22 00:10 comfyorange

You can still disable spectating the person by orbiting another target while auto-observe is off, which is weird.

Edit: this has been reverted, I see what you meant

jlsnow301 avatar Oct 29 '22 02:10 jlsnow301

Test Merge Removed

comfyorange avatar Oct 31 '22 18:10 comfyorange