checkit icon indicating copy to clipboard operation
checkit copied to clipboard

Fixed #45: custom messages for custom validators

Open mattiloh opened this issue 9 years ago • 1 comments

I added a test for the 'allow the use of custom messages on failed validation', too.

Unfortunately the test-setup seems not to work well with the promise-based interface of Checkit. Even failing tests are counted as passed and you only see the errors by scanning the test-list for thrown errors. I added a done-callback in a final then(done, done) to the Checkit-Promise of my test to make it work. All other tests should be updated, too. But I'll open an issue for that.

There seemed to be some un-built changes of former commits. So lines 718 + 897 of dist/checkit.js are unrelated to this fix and contain new messages for the field-type integer.

I also added webpack to package.json and changed the npm-scripts build and test to use local versions of mocha and webpack.

mattiloh avatar Nov 18 '15 17:11 mattiloh

Hi Rhys! Are there any suggestions on this?

mattiloh avatar Nov 30 '15 19:11 mattiloh