Neon.HomeControl icon indicating copy to clipboard operation
Neon.HomeControl copied to clipboard

Better SpotifyWebComponent

Open tgiachi opened this issue 6 years ago • 6 comments

In this moment, spotify can query devices and current playing song.

The characteristic features of:

  • Query songs
  • Playing song on device
  • Parse input commands (example send_command("PLAY_SONG", "artist - song", device_name) )

tgiachi avatar Jul 26 '19 12:07 tgiachi

So we probably want to support most player functionality, am I right?: Spotify API - Player

Done so far:

  • SET_VOLUME - Set volume on current or specified device. (was already there)
  • PAUSE - Pauses playing on current device.
  • PLAY_TRACK - Play a track on current or specified device.
  • PLAY_CONTEXT - Play an artist/album/playlist on current or specified device.
  • RESUME - Resume playing on current or specified device.

What's left:

  • NEXT - Skip to next track.
  • PREVIOUS - Skip to previous track.
  • SET_REPEAT - Set repeat mode.
  • SET_SHUFFLE - Set shuffle mode.

If I'm missing something, please let me know.

bkardol avatar Aug 02 '19 09:08 bkardol

Hi @bkardol, Yes is correct! I also think the possibility of searching for songs is useful, What do you think about it?

Thank you!

tgiachi avatar Aug 02 '19 09:08 tgiachi

@tgiachi , good one, I will include search functionality aswell.

Thanks for the quick reply!

bkardol avatar Aug 02 '19 09:08 bkardol

Regarding the search functionality: Should it be implemented with a command that puts its result in an event? Or should it be returned immediately from the command. If this is the case I think we need some adjustments in the EventBridge and DispatcherService.

Thanks!

bkardol avatar Aug 06 '19 07:08 bkardol

Hi @bkardol ! In my last commit (on master branch) i've added on SendCommand object result. Please try if works! Have a nice day

tgiachi avatar Aug 06 '19 09:08 tgiachi

Nice, I'll try it out. Thanks @tgiachi !

bkardol avatar Aug 06 '19 09:08 bkardol