simhashphp
simhashphp copied to clipboard
tgalopin
Fix 128bit SimHash, and add 256bit and 512bit SimHash
@tgalopin
I'm not sure what you want to fix in 128 bits version and why you need all the modifications you did.
first: "base_convert" in 128 bits version always return string content only zero symbols. (environment: php 7.1, windows 7).
second: php "bindec" dont corect work with 128-bit value how do you try to save 128-bit value in 32-bit float?
Hi guys,
I know what is to maintain an OSS project, but this PR looks good to me except a typo and the scalar type hint (except if you want to stop to maintain compatibility with older projects).
It is a good lib that helped me in the past, but now I am stuck with the error in 128 hashes.
How can I help?
Hello @bbalet !
The issue is that as @nicolaichuk didn't gave me access to code modification in this PR, I can't update his code, and using it without crediting him does not feel right in open-source :) . If you want to open a new PR based on his code, fixing the issues and adding a note in your commit message about @nicolaichuk, please don't hesitate to do so and I will review it happily :) !
@tgalopin
he issue is that as @nicolaichuk didn't gave me access to code modification in this PR
Option "Allow edits from maintainers" is selected in this PR.