python-axolotl-curve25519 icon indicating copy to clipboard operation
python-axolotl-curve25519 copied to clipboard

Published 20 hours ago • verified publisher icon tgalal

Correct types in PyModuleDef / fix compilation with new clang+gcc

Open hannob opened this issue 2 years ago • 4 comments

The 4th variable of PyModuleDef is an int, not a pointer: https://docs.python.org/3/c-api/module.html#c.PyModuleDef

Fixes compilation with clang.

hannob avatar Dec 02 '22 09:12 hannob

@tgalal could you please review? Currently, it is not possible to build python-axolotl-curve25519 with Clang.

mimi89999 avatar Apr 07 '23 17:04 mimi89999

I had the following error with Python 3.11 and this change solved the problem:

curve25519module.c:161:9: error: incompatible pointer to integer conversion initializing 'Py_ssize_t' (aka 'long') with an expression of type 'void *' [-Wint-conversion]

byildiz avatar Jul 24 '23 01:07 byildiz

@hannob @tgalal what's the progress right now? has it fixed? we get this error in mac m1, python3.10, can not install python-axolotl-curve25519

coldfire-x avatar May 07 '24 05:05 coldfire-x

This patch also fixes the build with GCC 14. Would be great if it could be merged.

glaubitz avatar Jun 26 '24 06:06 glaubitz