Boshi Lian comments

Results 223 comments of


                                            Boshi Lian

Issues with Mapkey Function

seem your Mapkey does not check downstream's key, no matter who the client is, you just map it to your private key this makes your ssh open to public, anyone...

Issues with Mapkey Function

maybe change to for key in [id_rsa, id_ecdsa, ... ] -> return readfile if exists?

i use it export and import in the same role, it have errors

this is due to some macro in bonus bar 6 (slot 133 - 144) typically, this should not happen could you please share `/dump GetActionInfo(133)` ?

Finding a way to not return "partial success" during authentication

hmm the easiest way to verify the theory is to use [v1.2.8](https://github.com/tg123/sshpiper/releases/tag/v1.2.8) partial success support introduced in 1.3.0 but sshpiper would still send support-method: publickey back to client side if...

Possible improvement for Watcher.Dispose()

i don't think waiting inside dispose is a good idea

Remove dependency to `Fractions`

agree with minimizing dependencies could you please send pr to remove it, i believe there are still many math related operations need it

KubernetesJson.Serialize fails due to null JsonSerializerInfo for V1Patch

this is a known issue, Patch is not supported in AOT at the moment :(

watcher: System.Net.Http.HttpRequestException: Error while copying content to a stream.

could you please put a retry outside your watcher?

watcher: System.Net.Http.HttpRequestException: Error while copying content to a stream.

this seems not a client side issue, probably server side closed the connection which is out of client side's control

KubernetesClient.Aot args IList<string> serialization error

seems so, would you like to send a pr to fix it? or i will pick it this weekend