Thorsten Frommen

Results 19 issues of Thorsten Frommen

Looking at the _Environment_ in Query Monitor, `display_errors` always shows `0`, no matter what the actual (original) setting. ![image](https://user-images.githubusercontent.com/6049306/111620338-dde60800-87e6-11eb-9c18-ce9a993993bc.png) The reason for this is that [`QM_Collector_PHP_Errors` changes this](https://github.com/johnbillion/query-monitor/blob/22b2828b0fb9f7fb8e117c875c042ef226d7ea66/collectors/php_errors.php#L41-L42). The value...

bug
collector:environment

When using `block.json` for managing a block's metadata, the block's name is already a part of that file; it is the only required property, actually. With the current version of...

The `declaration-property-unit-blacklist` and the `declaration-property-unit-whitelist` rules have been deprecated, and should be replaced with `declaration-property-unit-disallowed-list` and `declaration-property-unit-allowed-list`, respectively. This will be a **breaking** change, as user overrides won't work any...

stylelint

This PR introduces [PHIVE](https://github.com/phar-io/phive) to manage PHPUnit. For more information on PHIVE, please refer to the [official](https://phar.io) [website](https://phar.io/how-it-works.html). Instead of including PHPUnit as a Composer (dev) dependency, we would run...

The `PSR2R.Namespaces.UseInAlphabeticalOrder` rule has been [removed](https://github.com/php-fig-rectified/psr2r-sniffer/commit/3f602977f4eb9cb1c2bfadeef0f0131ee15986fb) from the [PSR-2-R](https://github.com/php-fig-rectified/psr2r-sniffer) standard, so we should remove it, too. As soon as we'd update the standard, it would break anyway. See #245.

The HM Coding Standards make use of the external [PSR-2-R](https://github.com/php-fig-rectified/psr2r-sniffer) standard. There are some issues with this. Currently, we are using the following three rules as part of the HM...

enhancement
phpcs

This PR adds a new sniff, `HM.PHP.Ternary` that adds a warning for unnecessary ternary expression, as mentioned in #154: * `$expr ? true : false`; * `$expr ? false :...

I'm having issues when I feed closures that `use` local variables into function calls, for example, `add_action()`. **Example `test.php` file:** ```php

Type: Bug
Upstream: PHPCS
Focus: Modern PHP
Component: Core

**Please check if the PR fulfills these requirements** - [ ] The commit message follows our guidelines - [ ] Tests for the changes have been added (for bug fixes/features)...