T. Franzel

Results 315 comments of T. Franzel

Thanks @dontic for doing the research and opening the issue. > Where they state they actually had a long thought on this issue when implementing webhooks. In the end, it...

Hi, thanks for the PR. I have not looked at this in a while. How much support do we gain with this change? Are there other changes necessary?

Hi, this is actually intended behavior as it closely resembles what DRF is actually doing. On response, those "not required" fields are basically always present. The `required` property of DRF...

Hi, so this functionality is basically already there, however it is only activated as a graceful fallback when there is no better alternative (i.e. there is a collision in naming...

Yes, the downside of this approach is that the names change depending on the general context. Usually django apps/projects are not wildly changing ever so often and so it is...

Hi, this has come up before years ago. For some reason browsers don't like to display yaml files. Chrome for example has no issues showing json, but always downloads the...

Hi, it is uncommon that fields behave differently on request and response, at least in the context of DRF. One of the few exceptions is the `FileField`. `@extend_schema_field` cannot cover...

Hi, so looks like a corner case in internal initialization. Unfortunately, you hit the one combination that is not properly dealt with. The others are already covered by tests. |...

Hi @bartvanandel, sry for the delay. Could you please rebase your change because the the GH worker image got retired and rescheduling the actions won't make use of the new...

Finally had some time to review. I think this looks good. However, I believe there is another conditional missing. Shouldn't this also be dependant on `USE_JWT`? https://github.com/iMerica/dj-rest-auth/blob/545fd1f4c9ae570216989a8f5a563dd938e038af/dj_rest_auth/views.py#L171