graphene-django-optimizer icon indicating copy to clipboard operation
graphene-django-optimizer copied to clipboard

Connections ignoring hints

Open OmegaDroid opened this issue 5 years ago • 3 comments

Hi again,

I noticed another issue where related relay connections were ignoring optimization_hints due to the resolver being nested inside partials so I've updated it to search down the partials chain to find the hints.

OmegaDroid avatar Oct 11 '19 11:10 OmegaDroid

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.29%. Comparing base (e6bede5) to head (3ebc788). Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   93.54%   93.29%   -0.26%     
==========================================
  Files           6        6              
  Lines         310      313       +3     
==========================================
+ Hits          290      292       +2     
- Misses         20       21       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-io avatar Oct 11 '19 11:10 codecov-io

^^ would be great if this was merged... @tfoxy

berkcoker avatar Jan 18 '21 03:01 berkcoker

we've implemented a similar solution to solve the same problem in our project. would be nice if it gets in 🙏

k1wdel avatar Oct 27 '21 09:10 k1wdel