NeverTooManyBooks icon indicating copy to clipboard operation
NeverTooManyBooks copied to clipboard

(feature request) full black theme as well as dark theme

Open realeatham opened this issue 10 months ago • 4 comments

See title

realeatham avatar Apr 16 '24 13:04 realeatham

Not sure what you mean?

The app offers (in Settings) to use Light/Dark or "follow-the-device day/night". If you as I suspect mean extra Themes to those, then I regret to say, but I currently have no plans. There are other things which will get priority.

tfonteyn avatar Apr 16 '24 14:04 tfonteyn

Yes, I meant another theme. Can you leave the issue open incase you or someone else wants to add it in the future?

realeatham avatar Apr 16 '24 14:04 realeatham

sure - but it will require some work, it's not just adding it to a list. Day/Night is something Android supports via an API. Extra Themes work slightly differently.

tfonteyn avatar Apr 16 '24 14:04 tfonteyn

@realeatham

Here's your chance - I implemented #46 in such a way that I can now support multiple themes.

My classic "Blue/Grey" scheme is defined in style name="Theme.App", in this source file

I don't know how familiar (if at all) you are with Android development or its color use? If you want to have a go with the Theme Builder perhaps?

And no worry, I don't expect a ready-solution; but if you can play around with that tool (or any other of your liking) and come up with color definitions for the "primary" and "secondary" colors (see above source code), there are 9 colors + 1 for the background to define. The "surface" colors I can extrapolate from those prim/sec colors.

tfonteyn avatar Jun 09 '24 15:06 tfonteyn