Tom Morris
Tom Morris
There are two more failed runs, each on a different test, on a recent PR. Attempt 1 https://github.com/OpenRefine/OpenRefine/actions/runs/18855128843/job/53800961011 ``` com.google.refine.extension.database.DatabaseServiceException: java.sql.SQLException: stmt pointer is closed at com.google.refine.extension.database.sqlite.SQLiteDatabaseService.getColumns(SQLiteDatabaseService.java:180) at com.google.refine.extension.database.sqlite.SQLiteDatabaseServiceTest.testGetColumns(SQLiteDatabaseServiceTest.java:179) ```...
The instance initialization code is buggy and susceptible to races. The PR (hopefully) fixes that.
This test is still flaky https://github.com/OpenRefine/OpenRefine/actions/runs/19439613761/job/55619386215?pr=7544 ``` [main] ERROR DBQueryResultImportReader - DatabaseServiceException com.google.refine.extension.database.DatabaseServiceException: java.sql.SQLException: stmt pointer is closed at com.google.refine.extension.database.sqlite.SQLiteDatabaseService.getRows(SQLiteDatabaseService.java:211) at com.google.refine.extension.database.DBQueryResultImportReader.getRowsOfCells(DBQueryResultImportReader.java:161) at com.google.refine.extension.database.DBQueryResultImportReader.getNextRowOfCells(DBQueryResultImportReader.java:120) at com.google.refine.importers.TabularImportingParserBase.readTable(TabularImportingParserBase.java:142) at com.google.refine.importers.TabularImportingParserBase.readTable(TabularImportingParserBase.java:108) at com.google.refine.extension.database.DatabaseImportController.parsePreview(DatabaseImportController.java:272)...
I didn't really highlight the biggest problem here which is that the two individuals that Amazon lists separately with individual roles are being imported as a **single** author. I've updated...
Note that, although the example has two different contribution roles, multiple contributors shouldn't get munged together even if they have the same role (or no role).
Should have included @hornc in the stakeholders - updated.
@Freso I think they overlap significantly (now that the issue number has been corrected from what I received in the email notification). The main difference is one of emphasis. This...
This is also only a slight superset of #7724
> There's no MARC identifier for authors defined in authors/identifiers.yml, though. MARC is the standard for bibliographic metadata used by libraries around the world, not an identifier type. It will...
This subject was [imported](https://openlibrary.org/works/OL19519415W?b=3&a=2&_compare=Comparer&m=diff) [from](https://openlibrary.org/books/OL26830133M/Binti?b=2&a=1&_compare=Comparer&m=diff) Better World Books which is infamous for providing garbage metadata, but we've been unable to convince the powers that be to stop importing from it....