Tom Morris

Results 686 comments of Tom Morris

Let's have another look at the test failure here

I had a quick look at the failing tests and it looks like they're all failing for the same reason - it's guessing that a CSV file is just a...

And congratulations on your first pull request merged!

@thadguidry sorry I missed your earlier ping. Since I don't know anything about JavaFX, I hadn't even looked at this PR. The problem that you're running into was introduced back...

@sunilnatraj Thanks for the update. I'll have another look. @ostephens David's comment on the Control interface says > * Interface of GREL controls such as if, forEach, forNonBlank, with. A...

An example of a run where the DMG wasn't produced is: https://github.com/OpenRefine/OpenRefine/actions/runs/10187510735 The mac_test_and_deploy job errored, but that didn't cause a build failure for some reason, which is a little...

It looks like the default for detach_retries if 5 (with one retry per second), so perhaps we could try increasing that. https://github.com/dmgbuild/dmgbuild/blob/f16f2c39c54a6a60b7276f3e0b6f8b566bd864f0/src/dmgbuild/core.py#L155 It isn't clear to me whether this is...

Unfortunately, the retry parameter isn't exposed via the CLI (I've asked for it to be [here](https://github.com/dmgbuild/dmgbuild/issues/128)), but it looks like the problem isn't terribly frequent, so we can probably live...

I patched the tool to expose the retry count to the command line https://github.com/dmgbuild/dmgbuild/pull/129 It should be available in 1.6.2 and later.

I think this is only a problem for files which don't have a known MIME type or a file extension which can be used to guess the format. If you...