redmine_merge_request_links icon indicating copy to clipboard operation
redmine_merge_request_links copied to clipboard

Published 20 hours ago • verified publisher icon tf

Redmine Pull request disappears

Open calvu opened this issue 5 years ago • 4 comments

Hello,

My setup:

  • Redmine 3.4.13 (also tested with 3.4.6)
  • Gitea 1.11.6
  • Plugin v2.22

Problem: Creating a pullrequest with the ticket number "#1234" within Gitea creates an entry in the Redmine Ticket. As soon as the pullrequest is closed, by Merge or Close, the entry disappears in the ticket. I have already looked at the Redmine DB and noticed the following behavior.

  • When a pull request is created, "merge_requests" and "issues_merge_requests" creates the corresponding entries in the table.
  • When merging a pull request, the entry is deleted from the "issues_merge_requests" table and no new one is created.

Greetings, Peter

calvu avatar Jun 18 '20 13:06 calvu

Maybe the webhook sent on close does not contain the description/body? Every time that is changed, the linked merge requests are updated.

I'm not using the Gitea integration myself. So I can only guess. Maybe @saitho who developed the adapter has more ideas?

tf avatar Jun 23 '20 06:06 tf

I am experiencing the same issue. Indeed the body is empty in gitea's PR merged/closed webhook payload.

jpraet avatar May 27 '21 08:05 jpraet

Maybe we can make the Gitea adater only update the description if the corresponding field is present? Happy to accept a PR that adds a test case similar to the existing ones with a webhook payload that represents this case and makes sure.

tf avatar May 27 '21 09:05 tf

It will be fixed on the Gitea side in the upcoming 1.14.3 patch release.

jpraet avatar May 31 '21 08:05 jpraet