moose icon indicating copy to clipboard operation
moose copied to clipboard

Merge `HostFixedTensor`, `MirFixedTensor`, and `RepFixedTensor`

Open mortendahl opened this issue 3 years ago • 0 comments

All three are structurally identical to

pub struct RepFixedTensor<RepRingT> {
    pub tensor: RepRingT,
    pub fractional_precision: u32,
    pub integral_precision: u32,
}

so maybe we should simply have a single SpecificFixedTensor instead. Naming wise, perhaps this should be FixedTensor, and the current FixedTensor becomes AbstractFixedTensor to highlight that it's an abstraction.

Note that a team discussion needs to happen before implementing this, once the implications of the changes are fully understood.

mortendahl avatar Jan 14 '22 12:01 mortendahl