moose icon indicating copy to clipboard operation
moose copied to clipboard

Error handling of Session.execute in modelled! macro

Open jvmncs opened this issue 3 years ago • 3 comments

During #520, we found it would be good to catch compilation errors for kernels in the modelled! macro (discussion). This was out of scope of #453, but should be addressed in follow up work.

jvmncs avatar Sep 10 '21 19:09 jvmncs

Note that this issue would require introducing error handling to all modeled ops, for example PlacementMean::mean (as well as other modeled traits) would now return Result<O> instead of O.

jvmncs avatar Sep 30 '21 17:09 jvmncs

what about other modelled traits such as

pub trait PlacementDeriveSeed<S: Session, KeyT, SeedT> {
    fn derive_seed(&self, sess: &S, sync_key: SyncKey, key: &KeyT) -> SeedT;
}

eric-capeprivacy avatar Nov 29 '21 08:11 eric-capeprivacy

will probably jump on this again now that Morten introduced a new Macro

eric-capeprivacy avatar Dec 10 '21 15:12 eric-capeprivacy