textpattern-default-theme icon indicating copy to clipboard operation
textpattern-default-theme copied to clipboard

"Second pass < 1" error

Open cara-tm opened this issue 3 years ago • 5 comments

Expected behaviour

No TXP warnings when Number of extra parser sweeps (Admin -> Preferences -> Advanced options) is set to 0

Actual behaviour

TXP preventing errors located into the search_display form.

Steps to reproduce

Set Advanced Preferences Number of extra parser sweeps to 0 value.

Additional information

As explain by @bloatware on the forum (see: https://forum.textpattern.com/viewtopic.php?pid=332178), the search_display form need some amendments:

<h1 itemprop="name"><txp:text item="search_results" /></h1>

<txp:search_result_count />
<txp:article[1] pgonly="1" pageby="10" />
<txp:if_search_results>
[...]

cara-tm avatar Dec 12 '21 15:12 cara-tm

Update: No more needed based on the very latest commits (ask to Devs).

Only this tag is required : <txp:article[1] pgonly="1" />

cara-tm avatar Dec 17 '21 05:12 cara-tm

That wasn't me.

etc avatar Apr 24 '22 07:04 etc

@cara-tm like this?...

https://github.com/textpattern/textpattern-default-theme/commit/636c2d7e96cc2fad020d56f93d6e3bf638361df4

@etc sorry, wrong person was referenced in original post. Please ignore!

philwareham avatar Apr 25 '22 08:04 philwareham

@etc sorry. Corrected above.

cara-tm avatar May 04 '22 02:05 cara-tm

Thanks!

etc avatar May 04 '22 03:05 etc

@philwareham

Maybe it is a place for a comment to newbies:

/* For "Number of extra parser sweeps" set to zero in "Advanced options" preferences (more info here: https://bit.ly/3iBde8m) */
<txp:article[1] pgonly="1" />

cara-tm avatar Dec 05 '22 07:12 cara-tm

I think (to test) you don't need this <txp:article[1] pgonly="1" /> tag at all if you replace

<txp:article class="article-list" wraptag="ul" />

with

<txp:article[1] class="article-list" wraptag="ul" />

bloatware avatar Dec 05 '22 09:12 bloatware

@bloatware: Yep. That seems to work (based on my tests) ;)

cara-tm avatar Dec 05 '22 09:12 cara-tm