com_connect icon indicating copy to clipboard operation
com_connect copied to clipboard

Textpack not populating public event

Open jools-r opened this issue 3 years ago • 3 comments

Am testing with Textpattern 4.9.0-dev (fafab03ecb966e0277ccc7affff5b096) and the current (4c03614f64325b42f439555904e25fcf4b98537e) version of com_connect.

On the public front-end I see the gTxt strings and in the database, I see the owner set to com_connect but an empty event column. If I manually set that to public the correct language strings show on the front end.

jools-r avatar Dec 08 '21 10:12 jools-r

Thanks for adding that. Just one thing: might I/this have inadvertently affected how gTxt strings are passed through in the email body? I only saw it flash by in testing today and don't want to bombard the client with more contact form test mails, but it looked as if the strings were not being replaced in the email body. Perhaps a false alarm or do you think that setting “public" might have affected that?

jools-r avatar Dec 08 '21 15:12 jools-r

Ack, yeah, some of them will probably need to be [Common]. Good catch.

Off the top of my head, anything that's designated as a default 'label' for any of the tags might be affected if you don't override those labels via an attribute, since they'll be used in the email body I think.

So , com_connect_text, com_connect_name, com_connect_email, com_connect_option, etc...

Bloke avatar Dec 08 '21 16:12 Bloke

Hmmm, if you get a chance and can repeat the untranslated strings thing, please let me know how. I removed the label attribute from a few fields in my contact form (an email field and a select list) and they came through as:

Email: <address>
Option: <the selected value>

capitalised, i.e. translated even though they're public. That was kind of expected/unexpected, but I guess it's still public code that's executing it.

Bloke avatar Dec 08 '21 22:12 Bloke