react-native-sdk icon indicating copy to clipboard operation
react-native-sdk copied to clipboard

Use of Ignores API not consistent with JS lib or CLI

Open andrewxhill opened this issue 6 years ago • 4 comments
trafficstars

Noticed there is an ignores.add method here. It's not consistent.

Seems like a nice helper, we could add it in the other clients as well

Or maybe we leave it here for now, but add the standard ignores paths too?

andrewxhill avatar May 02 '19 16:05 andrewxhill

Noticed @carsonfarmer did similar for Textile.messages(threadId) and Textile.likes(threadId) which are actually part of the Threads endpoint, /threads/:id/messages but seem like helpful organization in the client. I'll go see about adding a set of Textile.invites methods

andrewxhill avatar May 02 '19 17:05 andrewxhill

Nevermind! carson did that too

andrewxhill avatar May 02 '19 17:05 andrewxhill

what'll this guy think of next...

andrewxhill avatar May 02 '19 17:05 andrewxhill

i take it back. that was Textile.invites. but just went to add a Textile.ignores and it gets confusing when you have different ignore types, ignore block, ignore invite, remove file maybe. I'd say we should add the blocks methods to the mobile clients and move ignores to there.

andrewxhill avatar May 02 '19 17:05 andrewxhill