js-powergate-client icon indicating copy to clipboard operation
js-powergate-client copied to clipboard

chore: upgrade ipfs-http-client

Open achingbrain opened this issue 4 years ago • 4 comments

Description

There's an rc available for a new release of ipfs-http-client which has much improved typescript support.

The purpose of this PR is to get an early view on any incompatibilities which will arise so they can be fixed early and the release can be as smooth as possible.

Type of change

  • [ ] Dep update

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

achingbrain avatar May 04 '21 17:05 achingbrain

Hey thanks @achingbrain. I triggered the tests to run here, you can see the error related to ipfs utils and NodeReadableStream. Any idea what could be up there?

asutula avatar Jun 10 '21 21:06 asutula

Two other things:

Should there be a package.lock.json change?

Since it took me so long to get to this PR, I see there are ipfs-http-client releases up to 50.1.1... Do those newer releases include the changes you were interested in testing back when you created this PR?

asutula avatar Jun 10 '21 21:06 asutula

@carsonfarmer do I remember correctly that you also had problems with the latest ipfs-https-client recently?

asutula avatar Jun 10 '21 22:06 asutula

Not that I know of. I haven't touched the http client in a while.

carsonfarmer avatar Jun 11 '21 16:06 carsonfarmer