cloudflare-update-dnslink icon indicating copy to clipboard operation
cloudflare-update-dnslink copied to clipboard

Published 20 hours ago • verified publisher icon textileio

jq: error (at <stdin>:1): Cannot iterate over null (null)

Open moodysalem opened this issue 5 years ago • 6 comments

no visibility into what's happening when this thing doesn't work

moodysalem avatar Jun 25 '20 00:06 moodysalem

i tried running the curls locally with the secrets and it seems like it works fine

moodysalem avatar Jun 25 '20 00:06 moodysalem

https://github.com/Uniswap/uniswap-frontend/runs/805572599?check_suite_focus=true

moodysalem avatar Jun 25 '20 00:06 moodysalem

The issue is the example has CLOUDFLARE_TOKEN_ZONE_ID but the actual variable is CLOUDFLARE_ZONE_ID

moodysalem avatar Jun 25 '20 01:06 moodysalem

Action items:

  • Fix readme
  • On error response, echo the JSON body (which contains error details from cloudflare)

moodysalem avatar Jun 25 '20 13:06 moodysalem

I've created a fork of this that provides better error handling when things don't work to let you know why it's broken which should help address these issues: https://github.com/marketplace/actions/cloudflare-dnslink-update

PabiGamito avatar May 14 '21 00:05 PabiGamito

Hi @PabiGamito, why not create a PR to this repo with your fixes? We'd be happy to accept a PR. This repo, while quiet, is not unmaintained.

carsonfarmer avatar May 14 '21 00:05 carsonfarmer